[webkit-reviews] review denied: [Bug 25536] WebKit needs to expose an Element::spellcheck attribute to javascript : [Attachment 72002] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 10:03:08 PDT 2010


Sam Weinig <sam at webkit.org> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 25536: WebKit needs to expose an Element::spellcheck attribute to
javascript
https://bugs.webkit.org/show_bug.cgi?id=25536

Attachment 72002: Patch
https://bugs.webkit.org/attachment.cgi?id=72002&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72002&action=review

> WebCore/html/HTMLElement.idl:65
> +		    attribute boolean spellcheck;

This should probably use the [Reflect] extended attribute which would mean you
don't need the implementation of spellcheck/setSpellcheck in HTMLElement.h/cpp


More information about the webkit-reviews mailing list