[webkit-reviews] review denied: [Bug 48189] Cleanup createGlobalImageFileDescriptor in ClipboardWin : [Attachment 72035] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 48189: Cleanup createGlobalImageFileDescriptor in ClipboardWin
https://bugs.webkit.org/show_bug.cgi?id=48189

Attachment 72035: Patch
https://bugs.webkit.org/attachment.cgi?id=72035&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72035&action=review

> WebCore/platform/win/ClipboardWin.cpp:727
> +    CString content = makeString("[InternetShortcut]\r\nURL=", url,
"\r\n").ascii();

This doesn't do the same thing that the old code did. The old code converted
from UTF-16 to a multi-byte string using the current code page, while this
converts from UTF-16 to ASCII. That seems wrong if the URL contains non-ASCII
characters.