[webkit-reviews] review denied: [Bug 48189] Cleanup createGlobalImageFileDescriptor in ClipboardWin : [Attachment 71645] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 04:57:12 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 48189: Cleanup createGlobalImageFileDescriptor in ClipboardWin
https://bugs.webkit.org/show_bug.cgi?id=48189

Attachment 71645: Patch
https://bugs.webkit.org/attachment.cgi?id=71645&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
I think this patch would be a lot easier to review if you were to clean up
createGlobalUrlFileDescriptor and createGlobalURLContent without merging them
into writeURL (maybe even with a separate patch for each), and then merge them
into writeURL. As it currently stands there's so much changing at once that
it's hard to verify that the result is correct.


More information about the webkit-reviews mailing list