[webkit-reviews] review denied: [Bug 48407] Port ContextMenuItemWin.cpp to WinCE : [Attachment 72005] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 48407: Port ContextMenuItemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48407

Attachment 72005: Patch
https://bugs.webkit.org/attachment.cgi?id=72005&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72005&action=review

> WebCore/platform/win/ContextMenuItemWin.cpp:73
> +#if OS(WINCE)
> +    m_platformDescription->fMask = MIIM_TYPE;
> +#else
>      m_platformDescription->fMask = MIIM_FTYPE;
> +#endif

Maybe we could finesse this a little more by using a constant that is defined
to MIIM_TYPE on WinCE and MIIM_FTYPE on other versions of Windows? Or we could
define MIIM_FTYPE on WinCE.

> WebCore/platform/win/ContextMenuItemWin.cpp:88
>      if (subMenu) {
> -	   m_platformDescription->fMask |= MIIM_STRING | MIIM_SUBMENU;
> +	   m_platformDescription->fMask |= MIIM_SUBMENU;
>	   m_platformDescription->hSubMenu = subMenu->platformDescription();
>      } else
> -	   m_platformDescription->fMask |= MIIM_STRING | MIIM_ID;
> +	   m_platformDescription->fMask |= MIIM_ID;
> +
> +#if !OS(WINCE)
> +    m_platformDescription->fMask |= MIIM_STRING;
> +#endif

…and we could finesse this more by defining MIIM_STRING to 0 on WinCE.