[webkit-reviews] review denied: [Bug 48362] GTK: Update resource tracking when moving a frame between documents : [Attachment 71961] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 27 00:28:33 PDT 2010


Martin Robinson <mrobinson at webkit.org> has denied Jenn Braithwaite
<jennb at chromium.org>'s request for review:
Bug 48362: GTK: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48362

Attachment 71961: patch
https://bugs.webkit.org/attachment.cgi?id=71961&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71961&action=review

Looks great. Thanks for fixing this for GTK+. There is one small style issue.

> WebKit/gtk/webkit/webkitwebview.cpp:4584
> +    } else {
> +	 g_hash_table_remove(priv->subResources.get(), identifier);
> +    }

I think that WebKit style requires this last block to go without the curly
braces (since it's only one line).


More information about the webkit-reviews mailing list