[webkit-reviews] review denied: [Bug 48215] SVGTextElement supplemental transforms pre-multiplied but should be post-multiplied in animatedLocalTransform : [Attachment 71701] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 23:13:56 PDT 2010


Dirk Schulze <krit at webkit.org> has denied Shane Stephens
<shanestephens at google.com>'s request for review:
Bug 48215: SVGTextElement supplemental transforms pre-multiplied but should be
post-multiplied in animatedLocalTransform
https://bugs.webkit.org/show_bug.cgi?id=48215

Attachment 71701: Patch
https://bugs.webkit.org/attachment.cgi?id=71701&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Does this only apply to elements with local transform in combination of
animateMotion, what about animateTransform? If you need animation tests, you
should use the animation test api in svg/animations. Please take a look there.
Using setTimeout is definitely wrong.
If it does not only effect animateMotion, I'd like to see more tests.


More information about the webkit-reviews mailing list