[webkit-reviews] review denied: [Bug 48396] Siblings of floated elements should be cleared below the float if they are too wide to fit in the containing block. : [Attachment 71984] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 23:08:25 PDT 2010


Andy Estes <aestes at apple.com> has denied Andy Estes <aestes at apple.com>'s
request for review:
Bug 48396: Siblings of floated elements should be cleared below the float if
they are too wide to fit in the containing block.
https://bugs.webkit.org/show_bug.cgi?id=48396

Attachment 71984: Patch
https://bugs.webkit.org/attachment.cgi?id=71984&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71984&action=review

> WebCore/rendering/RenderBlock.cpp:4046
> +	       if (widthAtY == availableLogicalWidth())

This was a bad idea. availableLogicalWidth() only needs to be called once in
this function.


More information about the webkit-reviews mailing list