[webkit-reviews] review denied: [Bug 48322] Enable check-webkit-style on Qt files : [Attachment 71876] patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Ademar Reis
<ademar.reis at openbossa.org>'s request for review:
Bug 48322: Enable check-webkit-style on Qt files
https://bugs.webkit.org/show_bug.cgi?id=48322

Attachment 71876: patch
https://bugs.webkit.org/attachment.cgi?id=71876&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71876&action=review

Just a few minor comments.

> WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2517
> +		   and filename.find('/qt/') < 0

All the hardcoded checks here are for items that there isn't a generic
mechanism for.

There is a generic mechanism for excluding directories. You'll have to list
each directory but there aren't that many.

See _PATH_RULES_SPECIFIER in WebKitTools/Scripts/webkitpy/style/checker.py

> WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py:3722
> +	   self.assert_lint('QWhatever * d_ptr;', '', 'WebKit/qt/whatever.cpp')


I'm mildly confused. Why is there a space between * and QWhatever? I thought
this was  testing that the name d_ptr was let through (not that spacing around
* is allowed).