[webkit-reviews] review granted: [Bug 47517] Add DelayProcessor files : [Attachment 70637] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 47517: Add DelayProcessor files
https://bugs.webkit.org/show_bug.cgi?id=47517

Attachment 70637: Patch
https://bugs.webkit.org/attachment.cgi?id=70637&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=70637&action=review

Looks okay; r+'ing, but with one comment. Feel free to upload a revised patch.

> WebCore/webaudio/DelayProcessor.cpp:44
> +	   uninitialize();

Looking at this afresh, this block of code looks like something that should be
in the base class's destructor. Also, given that uninitialize() checks the
isInitialized() flag it doesn't seem necessary to have the "if" test.