[webkit-reviews] review granted: [Bug 42322] WebKitTestRunner needs to support layoutTestController.dumpBackForwardList : [Attachment 71944] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 16:55:48 PDT 2010


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 42322: WebKitTestRunner needs to support
layoutTestController.dumpBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42322

Attachment 71944: Patch
https://bugs.webkit.org/attachment.cgi?id=71944&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71944&action=review

This is going to need project changes for Qt and Windows.

> WebKit2/Shared/API/c/WKURL.cpp:44
> +    return toAPI(WebString::create(toImpl(url)->string()).leakRef());

This can call toCopiedAPI(toImpl(url)->string()) I believe.


More information about the webkit-reviews mailing list