[webkit-reviews] review requested: [Bug 48362] GTK: Update resource tracking when moving a frame between documents : [Attachment 71961] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 26 16:33:11 PDT 2010
Jenn Braithwaite <jennb at chromium.org> has asked for review:
Bug 48362: GTK: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48362
Attachment 71961: patch
https://bugs.webkit.org/attachment.cgi?id=71961&action=review
------- Additional Comments from Jenn Braithwaite <jennb at chromium.org>
This patch does not add ASSERTs in
FrameLoaderClient::dispatchDid{Finish/Fail}Loading to ensure that the test case
for bug 44713 would fail without this fix, because there are comments allowing
that a resource may not always be found by webkit_web_view_get_resource().
However, to test this change, I did put in the ASSERTs locally to verify the
test crashes without the fix, and passes with the fix.
More information about the webkit-reviews
mailing list