[webkit-reviews] review granted: [Bug 48378] [chromium] remove DEFER from test_expectations : [Attachment 71941] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 15:09:35 PDT 2010


Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 48378: [chromium] remove DEFER from test_expectations
https://bugs.webkit.org/show_bug.cgi?id=48378

Attachment 71941: Patch
https://bugs.webkit.org/attachment.cgi?id=71941&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71941&action=review

>From offline discussion, we agreed that adding WONTFIX isn't necessary.  r=me
with that change.

> LayoutTests/platform/chromium/test_expectations.txt:205
> -BUG36681 DEFER SKIP : java = TEXT
> +BUG36681 WONTFIX SKIP : java = TEXT

Nit: I think we shouldn't add WONTFIX.

> LayoutTests/platform/chromium/test_expectations.txt:2430
> -BUG42875 SKIP DEFER : fast/js/sputnik = TEXT
> +BUG42875 SKIP WONTFIX : fast/js/sputnik = TEXT

Nit: I think we shouldn't add WONTFIX.


More information about the webkit-reviews mailing list