[webkit-reviews] review granted: [Bug 48271] Support Appkit key bindings and custom key bindings in WebKit2 : [Attachment 71939] New patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 48271: Support Appkit key bindings and custom key bindings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48271

Attachment 71939: New patch
https://bugs.webkit.org/attachment.cgi?id=71939&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71939&action=review

r=me. We'll likely learn even more about all this while reimplementing input
method support!

> WebKit2/UIProcess/API/mac/PageClientImpl.mm:237
> +	   [m_wkView _setEventToResend:nativeEvent];

Can we say "_setEventBeingResent"?

> WebKit2/UIProcess/API/mac/WKView.mm:92
> +    NSEvent *_keyDownEventBeingResent; // We keep here the event when
resending it to
> +					  // the application to distinguish the
case of a new event from one 
> +					  // that has been already sent to
WebCore.

We usually prefer to have a long comment before code, rather than to have to
align it.