[webkit-reviews] review granted: [Bug 47715] Web Inspector: move frontend settings to local storage : [Attachment 71734] Comments addressed.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 47715: Web Inspector: move frontend settings to local storage
https://bugs.webkit.org/show_bug.cgi?id=47715

Attachment 71734: Comments addressed.
https://bugs.webkit.org/attachment.cgi?id=71734&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71734&action=review

> WebCore/inspector/front-end/inspector.js:604
> +    WebInspector.applicationSettings.dispatchEventToListeners("loaded");

Now that we load settings synchronously, we no longer need the listener. We
should always expect them to be available. You can remove this notification and
all the places that listen to settings load. Unless we go the DB way...
What about reading from multiple threads / removing keys. fishd had some
reservations on that front...