[webkit-reviews] review granted: [Bug 48367] Post any pending messages to the Injected Bundle in WebContext::processDidFinishLaunching instead of in WebContext::ensureWebProcess : [Attachment 71931] Post pending messages to the Injected Bundle in WebContext::processDidFinishLaunching

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jessie Berlin <jberlin at webkit.org>'s
request for review:
Bug 48367: Post any pending messages to the Injected Bundle in
WebContext::processDidFinishLaunching instead of in
WebContext::ensureWebProcess
https://bugs.webkit.org/show_bug.cgi?id=48367

Attachment 71931: Post pending messages to the Injected Bundle in
WebContext::processDidFinishLaunching
https://bugs.webkit.org/attachment.cgi?id=71931&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71931&action=review

> WebKit2/UIProcess/WebContext.cpp:192
> +	   pair<String, RefPtr<APIObject> >* message =
&m_pendingMessagesToPostToInjectedBundle[i];
> +	   m_process->send(InjectedBundleMessage::PostMessage, 0,
CoreIPC::In(message->first,
WebContextUserMessageEncoder(message->second.get())));

You are just moving this code, and didn’t write it. I would have used a
reference instead of a pointer here.