[webkit-reviews] review granted: [Bug 48360] Need a way to retrieve custom user agent from a WKPage : [Attachment 71929] [PATCH] Fix - rename to WKPageCopyCustomUserAgent
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 26 12:54:20 PDT 2010
Darin Adler <darin at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 48360: Need a way to retrieve custom user agent from a WKPage
https://bugs.webkit.org/show_bug.cgi?id=48360
Attachment 71929: [PATCH] Fix - rename to WKPageCopyCustomUserAgent
https://bugs.webkit.org/attachment.cgi?id=71929&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71929&action=review
> WebKit2/UIProcess/WebPageProxy.cpp:462
> + if (m_customUserAgent == userAgent)
> + return;
This code distinguishes a null string from an empty string. I’m not sure that’s
intentional.
More information about the webkit-reviews
mailing list