[webkit-reviews] review denied: [Bug 48321] [NRWT] Fix http lock on Windows platform : [Attachment 71875] proposed patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 48321: [NRWT] Fix http lock on Windows platform
https://bugs.webkit.org/show_bug.cgi?id=48321

Attachment 71875: proposed patch
https://bugs.webkit.org/attachment.cgi?id=71875&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71875&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/port/http_lock.py:78
> +	   FIXME: On Windows it's always return True."""
> +	   if sys.platform in ('darwin', 'linux2'):
> +	       try:
> +		   os.kill(current_pid, 0)

In webkitpy/common/system/executive.py, there's a kill_process function that
should work on windows.  Can we use that instead?

> WebKitTools/Scripts/webkitpy/layout_tests/port/http_lock.py:108
> +		   if sys.platform in ('darwin', 'linux2'):
> +		       guard_lock_flags |= os.O_NONBLOCK

Should we add 'cygwin' to the platform tuple?  It looks like cygwin python has
os.O_NONBLOCK, although I'm not sure if it does anything.