[webkit-reviews] review granted: [Bug 48339] Add a 'grammar' attribute for speech input. : [Attachment 71904] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Satish Sampath
<satish at chromium.org>'s request for review:
Bug 48339: Add a 'grammar' attribute for speech input.
https://bugs.webkit.org/show_bug.cgi?id=48339

Attachment 71904: Patch
https://bugs.webkit.org/attachment.cgi?id=71904&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71904&action=review

r=me

> WebCore/page/SpeechInputClient.h:34
> +#include <wtf/Forward.h>

Needed?

> WebCore/platform/mock/SpeechInputClientMock.cpp:53
> +bool SpeechInputClientMock::startRecognition(int requestId, const IntRect&,
const String&)

include name

> WebCore/platform/mock/SpeechInputClientMock.h:53
> +    bool startRecognition(int, const IntRect&, const String&);

include name

> WebKit/chromium/src/SpeechInputClientImpl.h:57
> +    bool startRecognition(int, const WebCore::IntRect&, const WTF::String&);


you should include a name here