[webkit-reviews] review denied: [Bug 46535] WebKit does not build when PLUGIN_PROXY_FOR_VIDEO is enabled : [Attachment 68804] build fixes plus crash fix

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Joe Mason <jmason at rim.com>'s
request for review:
Bug 46535: WebKit does not build when PLUGIN_PROXY_FOR_VIDEO is enabled
https://bugs.webkit.org/show_bug.cgi?id=46535

Attachment 68804: build fixes plus crash fix
https://bugs.webkit.org/attachment.cgi?id=68804&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68804&action=review

> WebCore/html/HTMLMediaElement.cpp:3
> + * Copyright (C) Research In Motion Limited 2010. All rights reserved.

I don't know if we have guidelines about this, but my own policy is to only add
a new copyright line when I make significant additions or changes to a file.


> WebCore/html/HTMLMediaElement.cpp:2182
> -    url = src();
> +    url = document()->completeURL(m_currentSrc);

This is not correct, m_currentSrc may not have been set at this point (it is
set a few lines later in this function). Use "getNonEmptyURLAttribute(srcAttr)"
instead.