[webkit-reviews] review granted: [Bug 25539] spellcheck='' should be the same as spellcheck="true" : [Attachment 71858] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 09:19:35 PDT 2010


Tony Chang <tony at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 25539: spellcheck='' should be the same as spellcheck="true"
https://bugs.webkit.org/show_bug.cgi?id=25539

Attachment 71858: Patch
https://bugs.webkit.org/attachment.cgi?id=71858&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71858&action=review

Is it possible to add a layout test for the !node crash?

> WebCore/editing/Editor.cpp:2552
> +    if (!node)
> +	   return false;

Note that the previous code returned true if !node, but it doesn't seem to
matter.


More information about the webkit-reviews mailing list