[webkit-reviews] review granted: [Bug 48335] [GTK] [review] Support for new-window in GtkLauncher : [Attachment 71894] Enable popup window in GtkLauncher

[bugzilla-daemon at webkit.org]

Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> has granted  review:
Bug 48335: [GTK] [review] Support for new-window in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=48335

Attachment 71894: Enable popup window in GtkLauncher
https://bugs.webkit.org/attachment.cgi?id=71894&action=review

------- Additional Comments from Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>
The GtkLauncher application does not support opening new window when a
"target=_blank" is clicked or similar call to window.open() is made withing a
user gesture. Instead, GtkLauncher does nothing. This prevents using
GtkLauncher for testing certain sites. The attach patch implement minimal
support for creating new window. This is done by implementing signals
"create-web-view", "web-view-ready" and "close-web-view".