[webkit-reviews] review requested: [Bug 48204] Convert SVGRect to the new SVGPropertyTearOff concept : [Attachment 71880] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 26 07:34:45 PDT 2010
Nikolas Zimmermann <zimmermann at kde.org> has asked for review:
Bug 48204: Convert SVGRect to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48204
Attachment 71880: Patch
https://bugs.webkit.org/attachment.cgi?id=71880&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Patch is larger than previously planned. I needed to refactor the
SVGPropertyTearOff type handling from all generators into CodeGenerator.pm, to
avoid adding hacks like s/SVGRect/FloatRect/ in all generators.
This also removes the need again for the temporary
SVGAnimatedProperty/SVGProperty/SVGListProperty markers in the idl files.
Tested with a Mac Leopard debug build, and a Chrome build on Snow Leopard.
More information about the webkit-reviews
mailing list