[webkit-reviews] review granted: [Bug 48278] Convert DumpRenderTree webarchive code to CoreFoundation : [Attachment 71820] Part 4: Rename WebArchiveDumpSupport.mm to WebArchiveDumpSupport.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 07:21:54 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 48278: Convert DumpRenderTree webarchive code to CoreFoundation
https://bugs.webkit.org/show_bug.cgi?id=48278

Attachment 71820: Part 4: Rename WebArchiveDumpSupport.mm to
WebArchiveDumpSupport.cpp
https://bugs.webkit.org/attachment.cgi?id=71820&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71820&action=review

> WebKitTools/ChangeLog:18
> +	   * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Renamed from
DumpRenderTree/mac/WebArchiveDumpSupport.mm.
> +	   (convertMIMEType):
> +	   (convertWebResourceDataToString):
> +	   (normalizeHTTPResponseHeaderFields):
> +	   (normalizeWebResourceURL):
> +	   (convertWebResourceResponseToDictionary):
> +	   (compareResourceURLs):
> +	   (createXMLStringFromWebArchiveData):

I usually leave out function names when doing a file rename.


More information about the webkit-reviews mailing list