[webkit-reviews] review denied: [Bug 48266] Fix IndexedDB crashes : [Attachment 71866] patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 48266: Fix IndexedDB crashes
https://bugs.webkit.org/show_bug.cgi?id=48266

Attachment 71866: patch
https://bugs.webkit.org/attachment.cgi?id=71866&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71866&action=review

>> LayoutTests/storage/indexeddb/keyrange.html:49
>> +	shouldBe("rightFlags", openRight ? "keyRange.RIGHT_OPEN |
keyRange.RIGHT_BOUND" : "keyRange.RIGHT_BOUND"); 
> 
> Intentional change?

no

>> LayoutTests/storage/indexeddb/objectstore-basics.html:50
>> +	debug("creatObjectStore():");
> 
> createObjectStore()

done

>> LayoutTests/storage/indexeddb/objectstore-basics.html:68
>> +	}
> 
> Seem to be some spurious diffs throughout this change. Is there any way you
can remove them to make clear what's going on?

I think Andrei introduced white space changes which my editor is fighting. 
Sorry about that.  I'll try generating a diff without white spaces.

>> WebCore/ChangeLog:11
>> +	    This is just a stop-gap move until we get it figured out upstream.
> 
> What do you mean by upstream?

In standards.  Changed.