[webkit-reviews] review denied: [Bug 48220] constraint validation: stepMismatch (rounding error) : [Attachment 71863] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 07:01:28 PDT 2010


Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 48220: constraint validation: stepMismatch (rounding error)
https://bugs.webkit.org/show_bug.cgi?id=48220

Attachment 71863: Patch
https://bugs.webkit.org/attachment.cgi?id=71863&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71863&action=review

> WebCore/html/NumberInputType.cpp:119
>      // is greater than step*2^DBL_MANT_DIG, the following fmod() makes no
sense.

Needs to update the comment.  fmod() won't be used.

> WebCore/html/NumberInputType.cpp:122
> +    double remainder = fabs(doubleValue - step * round(doubleValue / step));


Would you explain why we need to use fabs() instead of fmod() in a code comment
or ChangeLog please?

> WebCore/html/NumberInputType.cpp:123
> +    // Accepts errors in the equvalent precision to IEEE 754
single-precision

This comment is confusing.  "Accepts erros in lower fractional part which IEEE
754 single-precision can't represent." ?


More information about the webkit-reviews mailing list