[webkit-reviews] review granted: [Bug 46868] Input Method inserts conversion candidates unexpectedly : [Attachment 71859] A trial patch V2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 46868: Input Method inserts conversion candidates unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=46868

Attachment 71859: A trial patch V2
https://bugs.webkit.org/attachment.cgi?id=71859&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71859&action=review

- The test doesn't pass with Chromium test_shell.  So we had better add the
test to LayoutTest/platform/chromium/test_expectations.txt.

I still have some comments on the patch.  However, I think it's ok to commit
this.

>
LayoutTests/platform/chromium/fast/text/chromium-mac-duplicate-ime-composition.
html:5
> +	 var console = document.getElementById('console');

nit: We usually use 4-space indent for JavaScript code.

> WebKitTools/DumpRenderTree/chromium/TextInputController.cpp:254
> +    keyDown.windowsKeyCode = 0xE5; // VKEY_PROCESSKEY

We should add VKEY_PROCESSKEY to webkit/support/webkit_support.h of Chromium.