[webkit-reviews] review denied: [Bug 48221] Number values should be in the range of IEEE 754 single-precision floating point number : [Attachment 71851] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 48221: Number values should be in the range of IEEE 754 single-precision
floating point number
https://bugs.webkit.org/show_bug.cgi?id=48221

Attachment 71851: Patch
https://bugs.webkit.org/attachment.cgi?id=71851&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71851&action=review

> WebCore/html/NumberInputType.cpp:69
> +    if (newValue < numberDefaultMinimum) {

You need to add test cases for this change into
LayoutTests/fast/forms/script-tests/input-valueasnumber-number.js.

> WebCore/html/NumberInputType.cpp:73
> +    if (newValue > numberDefaultMaximum) {

ditto.