[webkit-reviews] review canceled: [Bug 47365] getTextAtOffset returns incorrect results if a link includes text and an image : [Attachment 71412] Patch proposal + unit test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 26 02:07:03 PDT 2010
Mario Sanchez Prada <msanchez at igalia.com> has canceled Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 47365: getTextAtOffset returns incorrect results if a link includes text
and an image
https://bugs.webkit.org/show_bug.cgi?id=47365
Attachment 71412: Patch proposal + unit test
https://bugs.webkit.org/attachment.cgi?id=71412&action=review
------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a new patch:
(In reply to comment #5)
> [...]
> > WebKit/gtk/tests/testatk.c:979
> > + g_idle_add((GSourceFunc)bail_out, loop);
> > + g_main_loop_run(loop);
>
> I think we should also try to iterate the main main loop here as well. I
think you're exploring that presently.
Fixed (by manually spinning the loop, which is still needed to get the
accessible objects)
Asking for review again
More information about the webkit-reviews
mailing list