[webkit-reviews] review granted: [Bug 48202] [GTK] Port to new GtkScrollable interface in GTK+ 3.x : [Attachment 71842] scrollable.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 26 01:24:09 PDT 2010


Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 48202: [GTK] Port to new GtkScrollable interface in GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=48202

Attachment 71842: scrollable.diff
https://bugs.webkit.org/attachment.cgi?id=71842&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71842&action=review

Okay. Patch looks great to me, but perhaps you might consider my suggestions
before landing. Thanks!

> WebKit/gtk/webkit/webkitwebview.cpp:203
> +#ifndef GTK_API_VERSION_2
> +    , PROP_HADJUSTMENT
> +    , PROP_VADJUSTMENT
> +#endif

I guess I prefer the original method to this one. :/

> WebKit/gtk/webkit/webkitwebview.cpp:398
> +static void setHorizontalAdjustment(WebKitWebView* webView, GtkAdjustment*
hadj)

My preference is to rename hadj/vadj to horizontalAdjustment/verticalAdjustment
before landing.


More information about the webkit-reviews mailing list