[webkit-reviews] review denied: [Bug 48221] Number values should be in the range of IEEE 754 single-precision floating point number : [Attachment 71838] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 48221: Number values should be in the range of IEEE 754 single-precision
floating point number
https://bugs.webkit.org/show_bug.cgi?id=48221

Attachment 71838: Patch
https://bugs.webkit.org/attachment.cgi?id=71838&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71838&action=review

> WebCore/html/parser/HTMLParserIdioms.cpp:66
> +	   number = -HUGE_VAL;

I don't think printing +-HUGE_VAL makes much sense, and huge values which are
out of the float range should not be passed to this function if other code
correctly handle minimum/maximum limits.

My concern is precision, not value range. Suppose that we have
  <input type=number step=0.005 min=4 value=5.005 >
and we call stepUp(2).	The value will be "5.015000000000001" because
serializeForNumberType() handles lower bits of the double value.  The value
should be "5.015".