[webkit-reviews] review requested: [Bug 48286] Fix Cache::dumpStats formatting : [Attachment 71837] [PATCH] Make Columns 13 Characters Wide

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 25 19:54:15 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 48286: Fix Cache::dumpStats formatting
https://bugs.webkit.org/show_bug.cgi?id=48286

Attachment 71837: [PATCH] Make Columns 13 Characters Wide
https://bugs.webkit.org/attachment.cgi?id=71837&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Now, none of the titles are too wide. Sample output:

    (gdb) p WebCore::cache()->dumpStats()
		  Count 	Size	      LiveSize	    DecodedSize  
PurgeableSize PurgedSize   
    ------------- ------------- ------------- ------------- -------------
------------- -------------
    Images		     38       3965777	    3948921	  3053452      
      0 	    0
    CSS 		      3 	66663	      66663		0      
      0 	    0
    XSL 		      0 	    0		  0		0      
      0 	    0
    JavaScript		      4        406906	     406906		0      
      0 	    0
    Fonts		      0 	    0		  0		0      
      0 	    0
    ------------- ------------- ------------- ------------- -------------
------------- -------------

Note, there could also be a bunch of improvements to add XBL to this list.
However, I don't know anyone that actually uses XBL, so I didn't take the time
to add it to the list. Let me know if that is a desired improvement. I don't
think this output is actually used anywhere in tests, but I'm running tests
overnight anyways to see.


More information about the webkit-reviews mailing list