[webkit-reviews] review granted: [Bug 47848] [chromium] Check getGraphicsResetStatusARB and reinitialize the renderer in an error is returned. : [Attachment 71376] addressed comments

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Alexey Marinichev
<amarinichev at chromium.org>'s request for review:
Bug 47848: [chromium] Check getGraphicsResetStatusARB and reinitialize the
renderer in an error is returned.
https://bugs.webkit.org/show_bug.cgi?id=47848

Attachment 71376: addressed comments
https://bugs.webkit.org/attachment.cgi?id=71376&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71376&action=review

This looks good. Couple of tiny comments, not necessary to address (marking
cq+).

> WebCore/ChangeLog:6
> +	   renderer in an error is returned.

in -> if

> WebKit/chromium/ChangeLog:6
> +	   renderer in an error is returned.

in -> if

> WebKit/chromium/src/WebViewImpl.cpp:2489
> +    RefPtr<LayerRendererChromium> layerRenderer =
LayerRendererChromium::create(newContext);

Strictly speaking this should probably be newContext.release().