[webkit-reviews] review denied: [Bug 48152] Implement copyTextureToParentTextureCHROMIUM in WebGraphicsContext3DDefaultImpl. : [Attachment 71747] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 48152: Implement copyTextureToParentTextureCHROMIUM in
WebGraphicsContext3DDefaultImpl.
https://bugs.webkit.org/show_bug.cgi?id=48152

Attachment 71747: Patch
https://bugs.webkit.org/attachment.cgi?id=71747&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71747&action=review

This basically looks good but one issue.

> WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:580
> +    glGetTexLevelParameteriv(GL_TEXTURE_2D, 0, GL_TEXTURE_WIDTH, &width);

Please guard this call either with a call to gfx::GetGLImplementation()
(app/gfx/gl/gl_implementation.h) or a test of whether glGetTexLevelParameteriv
is NULL. Actually, in the current structure,
supportsCopyTextureToParentTextureCHROMIUM should return false if this function
is not available. This should prevent crashes when running on ANGLE or a pure
GLES2 implementation. See https://bugs.webkit.org/show_bug.cgi?id=48282 .