[webkit-reviews] review granted: [Bug 47391] Fix scrolling of noncomposited iframes within composited document : [Attachment 71822] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 25 17:20:27 PDT 2010


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 47391: Fix scrolling of noncomposited iframes within composited document
https://bugs.webkit.org/show_bug.cgi?id=47391

Attachment 71822: Patch
https://bugs.webkit.org/attachment.cgi?id=71822&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=71822&action=review

> WebCore/page/FrameView.cpp:1011
> +	       IntRect rect(0, 0, visibleWidth(), visibleHeight());
> +	       // Add borders and padding.
> +	       rect.move(frameRenderer->borderLeft() +
frameRenderer->paddingLeft(),
> +			 frameRenderer->borderTop() +
frameRenderer->paddingTop());

How about initializing the rect with the correct origin?


More information about the webkit-reviews mailing list