[webkit-reviews] review granted: [Bug 48265] Web Inspector: stub out basic WebInspector API and objects for WebKit2 : [Attachment 71797] Proposed Change

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 48265: Web Inspector: stub out basic WebInspector API and objects for
WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48265

Attachment 71797: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=71797&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71797&action=review

Looks great! r=me with some comments.

> WebKit2/UIProcess/WebPageProxy.h:112
> +    WebInspectorProxy* inspector() const;

I don't think inspector() needs to be const.

> WebKit2/UIProcess/WebPageProxy.h:329
> +    mutable RefPtr<WebInspectorProxy> m_inspector;

And then you can remove mutable here (and get rid of the const_cast in the
create function).

> WebKit2/WebProcess/WebPage/WebPage.h:99
> +    WebInspector* inspector() const;

Same comment about inspector being const here.