[webkit-reviews] review granted: [Bug 48273] Update the fake Carbon window when the window frame changes : [Attachment 71807] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 25 15:52:52 PDT 2010


mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 48273: Update the fake Carbon window when the window frame changes
https://bugs.webkit.org/show_bug.cgi?id=48273

Attachment 71807: Patch
https://bugs.webkit.org/attachment.cgi?id=71807&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=71807&action=review

> WebKit2/UIProcess/API/mac/WKView.mm:415
> +    NSScreen *screen = [window screen]; // nil if the window is off-screen
> +    if (screen)
> +	   return screen;

You can move the definition of 'screen' into the if statement.


More information about the webkit-reviews mailing list