[webkit-reviews] review granted: [Bug 29164] execCommand('removeFormat') adds extra styles inside tables : [Attachment 71795] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 25 15:14:04 PDT 2010


Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 29164: execCommand('removeFormat') adds extra styles inside tables
https://bugs.webkit.org/show_bug.cgi?id=29164

Attachment 71795: Patch
https://bugs.webkit.org/attachment.cgi?id=71795&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71795&action=review

> LayoutTests/editing/execCommand/remove-format-in-table-cell.html:8
> +Markup.description('This tests RemoveFormant command "hello". "hello" should
be the immediate child of td below and there should be no style attribute.');

Nit: I'm not sure what 'This tests RemoveFormant command "hello".' means.  Can
you rewrite it?  Something like:
This tests that RemoveFormat doesn't add extra span tags when inside a table
cell.


More information about the webkit-reviews mailing list