[webkit-reviews] review granted: [Bug 17926] Unformat deletes images : [Attachment 71792] Patch

Mon Oct 25 14:25:54 PDT 2010

Ojan Vafai <ojan at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 17926: Unformat deletes images
https://bugs.webkit.org/show_bug.cgi?id=17926

Attachment 71792: Patch
https://bugs.webkit.org/attachment.cgi?id=71792&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71792&action=review

> LayoutTests/editing/execCommand/remove-format-image.html:2
> +<html>

Don't need this tag. It just adds clutter. The doctype is useful because it
forces standards mode though.

> LayoutTests/editing/execCommand/remove-format-image.html:3
> +<body onload="runTests();">

Do you need to run this onload? Can't you just run the script inline? If you do
that, you won't need the body tag in the test.

> LayoutTests/editing/execCommand/remove-format-image.html:5
> +<div id="test1" contenteditable><storng>hello</strong> <img
src="../resources/abe.png"> world</div>

typo:storng