[webkit-reviews] review granted: [Bug 48257] Make "rl" and "bt" writing-modes work for blocks and lines. : [Attachment 71781] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 48257: Make "rl" and "bt" writing-modes work for blocks and lines.
https://bugs.webkit.org/show_bug.cgi?id=48257

Attachment 71781: Patch
https://bugs.webkit.org/attachment.cgi?id=71781&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=71781&action=review

> WebCore/rendering/InlineBox.h:293
> +    void adjustForFlippedBlocksWritingMode(int& x, int& y);

It’s sad the we keep adding (int, int) methods instead of IntPoint methods.

> WebCore/rendering/InlineTextBox.cpp:904
> +void InlineTextBox::paintTextMatchMarker(GraphicsContext* pt,  const
IntPoint& boxOrigin, const DocumentMarker& marker, RenderStyle* style, const
Font& font)

Extra space before const IntPoint