[webkit-reviews] review granted: [Bug 47834] Refactor HTMLInputElement: Move createRender(), appendFormData(), saveFormControlState() and restoreFormControlState() to InputTypes. : [Attachment 71536] Patch 2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 47834: Refactor HTMLInputElement: Move createRender(), appendFormData(),
saveFormControlState() and restoreFormControlState() to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=47834

Attachment 71536: Patch 2
https://bugs.webkit.org/attachment.cgi?id=71536&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=71536&action=review

> WebCore/html/HTMLInputElement.h:206
> +    bool activeSubmit() const { return m_activeSubmit; }

This data member and function don’t have a great name. In fact I have no idea
what the boolean means.

> WebCore/html/InputType.h:49
> +// One of InputType classes represents a type of HTMLInputElement.
> +// Do not expose insntances of InputType and its subclasses to classes other

> +// than HTMLInputElement.

The phrase “one of InputType classes” is not quite right here. I would word it
more like this, “An InputType object represents the type-specific part of an
HTMLInputElement.”

Typo: "insntances".

The term “subclasses” is not a C++ term. Instead we should say “InputType and
classes derived from it”.