[webkit-reviews] review requested: [Bug 48227] [GTK] Handle surrogate pairs in TextBreakIteratorGtk : [Attachment 71728] Patch to handle surrogate pairs in TextBreakIteratorGtk

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 48227: [GTK] Handle surrogate pairs in TextBreakIteratorGtk
https://bugs.webkit.org/show_bug.cgi?id=48227

Attachment 71728: Patch to handle surrogate pairs in TextBreakIteratorGtk
https://bugs.webkit.org/attachment.cgi?id=71728&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
TextBreakIteratorGtk uses utf8 because it's what pango expects, but we need to
return indices for the given input string that it's in utf16. The number of
characters is the same for both utf16 and ut8 except when the input string
contains surrogate pairs. We need to keep both, the index for the utf8 string
to be used internally, and the index for the utf16 string to be used as return
value of the iterator interface. It fixes test
fast/forms/textarea-maxlength.html