[webkit-reviews] review granted: [Bug 48216] Need a way to determine the screen rect for a form control in WebKit2 : [Attachment 71703] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Sam Weinig <sam at webkit.org>'s request for review:
Bug 48216: Need a way to determine the screen rect for a form control in
WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48216

Attachment 71703: Patch
https://bugs.webkit.org/attachment.cgi?id=71703&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=71703&action=review

> WebCore/dom/Element.cpp:485
> +    IntRect result = quads[0].enclosingBoundingBox();
> +    for (size_t i = 1; i < quads.size(); ++i)
> +	   result.unite(quads[i].enclosingBoundingBox());

Can just start with the empty rect and start the loop from 0, but I guess this
is slightly more efficient.

> WebCore/dom/Element.cpp:489
> +    FrameView* view = document()->view();
> +    if (!view)
> +	   return IntRect();

This can go closer to the beginning.

> WebKit2/WebKit2.xcodeproj/project.pbxproj:481
> -			remoteGlobalIDString = C0CE72851247E66800BC0EC4 /*
Derived Sources */;
> +			remoteGlobalIDString = C0CE72851247E66800BC0EC4;

Don’t land this.