[webkit-reviews] review requested: [Bug 48185] build-webkit: add support for --progress-tag switch : [Attachment 71696] proposed buildfix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 24 13:36:46 PDT 2010


Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 48185: build-webkit: add support for --progress-tag switch
https://bugs.webkit.org/show_bug.cgi?id=48185

Attachment 71696: proposed buildfix
https://bugs.webkit.org/attachment.cgi?id=71696&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
Before this patch:
ENABLE_METER_TAG=1
ENABLE_PROGRESS_TAG=1

After this patch:
ENABLE_METER_TAG=1
ENABLE_PROGRESS_TAG=0

There were build fail, because METER_TAG depends on PROGRESS_TAG:
RenderMeter class inherited from RenderIndicator in rendering/RenderMeter.h
But after this patch RenderIndicator.h wasn't included in RenderMeter.h
It is only included undirectly by RenderProgress.h if PROGRESS_TAG is enabled.
I don't think if METER_TAG needs PROGRESS_TAG, but RenderIndicator class.


More information about the webkit-reviews mailing list