[webkit-reviews] review denied: [Bug 46122] Check endianness with __BIG_ENDIAN in RVCT. : [Attachment 68140] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 46122: Check endianness with __BIG_ENDIAN in RVCT.
https://bugs.webkit.org/show_bug.cgi?id=46122

Attachment 68140: Patch
https://bugs.webkit.org/attachment.cgi?id=68140&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68140&action=review

r- to update the test

> JavaScriptCore/wtf/Platform.h:213
> +#if defined(__ARMEB__) || defined(__BIG_ENDIAN) /* RVCT defines __BIG_ENDIAN
*/

Please use this instead since it's self-documenting:

    #if deined(__ARMEB__) || COMPILER(RVCT) && defined(__BIG_ENDIAN)