[webkit-reviews] review denied: [Bug 32828] WTF should have an arraysize macro : [Attachment 71663] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 24 07:22:14 PDT 2010
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 32828: WTF should have an arraysize macro
https://bugs.webkit.org/show_bug.cgi?id=32828
Attachment 71663: Patch
https://bugs.webkit.org/attachment.cgi?id=71663&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r- due to various build failures.
I'm a little concerned about ARRAY_LENGTH() being too generic of a name. What
about WTF_ARRAY_LENGTH()?
Can you make the macro an inline template method instead, or does that make
declarations like this unhappy?
unsigned int toklen[ARRAY_LENGTH(tokens)];
More information about the webkit-reviews
mailing list