[webkit-reviews] review granted: [Bug 48179] Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement it properly : [Attachment 71677] Patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 24 03:32:07 PDT 2010
Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 48179: Convert SVGAngle to the new SVGPropertyTearOff concept, reimplement
it properly
https://bugs.webkit.org/show_bug.cgi?id=48179
Attachment 71677: Patch v3
https://bugs.webkit.org/attachment.cgi?id=71677&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71677&action=review
> WebCore/bindings/scripts/CodeGeneratorJS.pm:1848
> + push(@implContent, " if
(!ec)\n");
> + push(@implContent, "
imp->commitChange();\n");
Indention looks wrong
Looks great, please take a look at the bots, since EWS will take some while.
r=me
More information about the webkit-reviews
mailing list