[webkit-reviews] review granted: [Bug 48173] EWS never removes invalid patch ids : [Attachment 71624] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 48173: EWS never removes invalid patch ids
https://bugs.webkit.org/show_bug.cgi?id=48173

Attachment 71624: Patch
https://bugs.webkit.org/attachment.cgi?id=71624&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71624&action=review

>> WebKitTools/Scripts/webkitpy/tool/commands/queues.py:214
>> +		# FIXME: Using a fake patch because release_work_item has the
wrong API.
>> +		# We also don't really need to release the lock (although
that's fine),
>> +		# mostly we just need to remove this bogus patch from our
queue.
>> +		# If for some reason bugzilla is just down, then it will be
re-fed later.
>> +		patch = Attachment({'id': patch_id}, None)
> 
> :(

I still think this fake attachment is sadness.	Will you buy me a pony if this
code is still here in a month?