[webkit-reviews] review requested: [Bug 48199] [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) : [Attachment 71665] patch v0.2 - feedback wanted
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 23 19:34:29 PDT 2010
Antonio Gomes <tonikitoo at webkit.org> has asked for review:
Bug 48199: [GTK] Implement DumpRenderTreeSupportGtk (similarly to
DumpRenderTreeSupportQt idea)
https://bugs.webkit.org/show_bug.cgi?id=48199
Attachment 71665: patch v0.2 - feedback wanted
https://bugs.webkit.org/attachment.cgi?id=71665&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
same as v0.1, but builds and also fixed the below code:
#include "../../../WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h" is now
#include "WebCoreSupport/DumpRenderTreeSupportGtk.h"
However the below is still a problem:
Programs_DumpRenderTree_LDADD = \
libwebkitgtk- at WEBKITGTK_API_MAJOR_VERSION@. at WEBKITGTK_API_MINOR_VERSION@.la \
+
WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-DumpRenderTreeSupportGtk.o
\
More information about the webkit-reviews
mailing list