[webkit-reviews] review requested: [Bug 48199] [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) : [Attachment 71664] patch v0.1 - feedback wanted

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 48199: [GTK] Implement DumpRenderTreeSupportGtk (similarly to
DumpRenderTreeSupportQt idea)
https://bugs.webkit.org/show_bug.cgi?id=48199

Attachment 71664: patch v0.1 - feedback wanted
https://bugs.webkit.org/attachment.cgi?id=71664&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
I quickly prototyped that on Friday and showed it to Martin on IRC.

Summary:

1) Patch add WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp|h. This
class will basically group together a bunch of static methods to be called by
LayoutTestControllerGtk. (see for example
http://trac.webkit.org/browser/trunk/WebKit/qt/WebCoreSupport/DumpRenderTreeSup
portQt.cpp)

2) As an illustration, I added the linksIncludedInFocusChain method, which
should fix bug 47793 and unskip fast/events/tab-focus-anchor.html.

To make it to link, so far I did:

diff --git a/WebKitTools/GNUmakefile.am b/WebKitTools/GNUmakefile.am
index 5257ece..faa1dd5 100644
--- a/WebKitTools/GNUmakefile.am
+++ b/WebKitTools/GNUmakefile.am
@@ -97,6 +97,7 @@ Programs_DumpRenderTree_CFLAGS = \
 
 Programs_DumpRenderTree_LDADD = \
       
libwebkitgtk- at WEBKITGTK_API_MAJOR_VERSION@. at WEBKITGTK_API_MINOR_VERSION@.la \
+      
WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-DumpRenderTreeSupportGtk.o
\

please advice a better way. I am not pleased with that (and it is been possibly
making the patch not-functional ...)

Also if this can be improved, it would be great:

--- a/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp
+++ b/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp
@@ -32,6 +32,7 @@
 #include "config.h"
 #include "DumpRenderTree.h"
 
+#include "../../../WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h"



Thoughts?