[webkit-reviews] review denied: [Bug 48190] [WINCE] Port COMPtr.h to WinCE : [Attachment 71646] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 23 10:57:28 PDT 2010
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 48190: [WINCE] Port COMPtr.h to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48190
Attachment 71646: Patch
https://bugs.webkit.org/attachment.cgi?id=71646&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71646&action=review
r- to fix header sort order since this is a cq? patch.
> WebCore/platform/win/COMPtr.h:35
> +#include <wtf/Assertions.h>
> +#include <wtf/HashTraits.h>
> #include <unknwn.h>
Nit: <unkwn.h> is alphabetically before <wtf/...h>. Please realphabetize.
> WebCore/platform/win/COMPtr.h:-36
> -#include <WTF/Assertions.h>
> -#include <WTF/HashTraits.h>
Nice catch re: WTF!
More information about the webkit-reviews
mailing list